Skip to content

Check to account ExistentialDeposit #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2021
Merged

Check to account ExistentialDeposit #522

merged 2 commits into from
Jun 17, 2021

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Jun 15, 2021

No description provided.

@zjb0807 zjb0807 requested a review from xlc June 15, 2021 09:28
@zjb0807 zjb0807 mentioned this pull request Jun 15, 2021
Merged
@zjb0807 zjb0807 changed the title Checkout to account ExistentialDeposit Check to account ExistentialDeposit Jun 15, 2021
@xlc xlc requested review from wangjj9219 and shaunxw June 15, 2021 12:09
xlc
xlc approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine but better to have additional pair of eyes

shaunxw
shaunxw approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, docstring of do_transfer needs update to match the changes.

@zjb0807 zjb0807 merged commit 1718251 into master Jun 17, 2021
@zjb0807 zjb0807 deleted the add-check-to-existential-deposit branch June 17, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

@shaunxw shaunxw shaunxw approved these changes

@wangjj9219 wangjj9219 Awaiting requested review from wangjj9219

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zjb0807 @xlc @shaunxw