Skip to content

Refactor tokens #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2021
Merged

Refactor tokens #565

merged 6 commits into from
Jul 26, 2021

Conversation

wangjj9219
Copy link
Contributor

@wangjj9219 wangjj9219 commented Jul 21, 2021

Refactor as follows:

  1. unify the handling for ED for MutilCurrency(deposit, withdraw, transfer) between orml-tokens and the adapter for pallet-balances .
  2. do some general abstract
  3. add some calls to facilitate the separate use of orml-tokens

@xlc xlc requested a review from shaunxw July 23, 2021 01:37
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #565 (a795c73) into master (9ddd4da) will increase coverage by 1.40%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   72.68%   74.08%   +1.40%     
==========================================
  Files          76       76              
  Lines        5443     5741     +298     
==========================================
+ Hits         3956     4253     +297     
- Misses       1487     1488       +1     
Impacted Files Coverage Δ
tokens/src/weights.rs 0.00% <0.00%> (ø)
tokens/src/lib.rs 85.94% <92.90%> (+3.37%) ⬆️
tokens/src/mock.rs 32.00% <100.00%> (-1.34%) ⬇️
tokens/src/tests.rs 100.00% <100.00%> (ø)
tokens/src/imbalances.rs 13.88% <0.00%> (-2.78%) ⬇️
xtokens/src/lib.rs 65.74% <0.00%> (ø)
authority/src/mock.rs 74.46% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddd4da...a795c73. Read the comment docs.

@wangjj9219 wangjj9219 marked this pull request as ready for review July 23, 2021 06:31
@wangjj9219 wangjj9219 requested a review from xlc July 26, 2021 06:31
@wangjj9219 wangjj9219 merged commit 8895f4b into master Jul 26, 2021
@wangjj9219 wangjj9219 deleted the refactor-tokens branch July 26, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants