Skip to content

refactor bencher to track storage changes #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Dec 11, 2021
Merged

refactor bencher to track storage changes #570

merged 31 commits into from
Dec 11, 2021

Conversation

ermalkaleci
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021 •
edited
Loading

Codecov Report

Merging #570 (bd6dee2) into master (1f52034) will decrease coverage by 2.39%.
The diff coverage is 0.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   76.46%   74.06%   -2.40%     
==========================================
  Files          78       84       +6     
  Lines        6772     6991     +219     
==========================================
  Hits         5178     5178              
- Misses       1594     1813     +219
Impacted Files Coverage Δ
bencher/bencher-procedural/src/lib.rs 0.00% <0.00%> (ø)
bencher/src/bencher.rs 0.00% <0.00%> (ø)
bencher/src/build_wasm/wasm_project.rs 0.00% <0.00%> (ø)
bencher/src/ext.rs 0.00% <0.00%> (ø)
bencher/src/handler.rs 0.00% <0.00%> (ø)
bencher/src/tracker.rs 0.00% <0.00%> (ø)
bencher/src/utils.rs 0.00% <0.00%> (ø)
bencher/test/src/lib.rs 0.00% <0.00%> (ø)
bencher/test/src/mock.rs 0.00% <0.00%> (ø)
bencher/test/src/weights.rs 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f52034...bd6dee2. Read the comment docs.

@xlc
Copy link
Member

xlc commented Sep 24, 2021

need a merge master

@ermalkaleci ermalkaleci marked this pull request as ready for review December 9, 2021 11:58
@ermalkaleci ermalkaleci enabled auto-merge (squash) December 9, 2021 12:34
@xlc xlc requested review from shaunxw and ferrell-code December 9, 2021 23:50
ferrell-code
ferrell-code reviewed Dec 11, 2021
View reviewed changes
bencher/test/src/lib.rs
Comment on lines +18 to +22
#[pallet::config]
pub trait Config: frame_system::Config {}

#[pallet::hooks]
impl<T: Config> Hooks<T::BlockNumber> for Pallet<T> {}
Copy link
Contributor

@ferrell-code ferrell-code Dec 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for empty hooks... Just semantics not important at all

ferrell-code
ferrell-code reviewed Dec 11, 2021
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add bencher/test to root Cargo.toml workspace

@ermalkaleci ermalkaleci merged commit 88f1b4b into master Dec 11, 2021
@ermalkaleci ermalkaleci deleted the refactor_bencher branch December 11, 2021 05:43
@ferrell-code
Copy link
Contributor

Awesome bencher update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrell-code ferrell-code ferrell-code approved these changes

@shaunxw shaunxw Awaiting requested review from shaunxw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ermalkaleci @codecov-commenter @xlc @ferrell-code