Skip to content

migrate to mutate_exist #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

ferrell-code
Copy link
Contributor

closes #596

Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some new tests to verify the storage is removed

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #597 (7e6a19a) into master (5712c07) will increase coverage by 0.14%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   75.38%   75.52%   +0.14%     
==========================================
  Files          76       76              
  Lines        5931     5945      +14     
==========================================
+ Hits         4471     4490      +19     
+ Misses       1460     1455       -5     
Impacted Files Coverage Δ
bencher/src/build_wasm/mod.rs 0.00% <ø> (ø)
bencher/src/build_wasm/wasm_project.rs 0.00% <0.00%> (ø)
bencher/src/handler.rs 0.00% <0.00%> (ø)
nft/src/lib.rs 84.61% <0.00%> (ø)
tokens/src/mock.rs 26.76% <ø> (ø)
xtokens/src/lib.rs 71.91% <0.00%> (ø)
benchmarking/src/lib.rs 30.08% <68.96%> (ø)
rewards/src/lib.rs 82.35% <77.77%> (+0.81%) ⬆️
auction/src/tests.rs 100.00% <100.00%> (ø)
authority/src/mock.rs 73.46% <100.00%> (+1.12%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5babe0b...7e6a19a. Read the comment docs.

@xlc xlc merged commit 74d290d into open-web3-stack:master Sep 1, 2021
@ferrell-code ferrell-code deleted the fer-clean-up-shares branch September 1, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orml-rewards not clean up shares
3 participants