make authorize_call free and operational #609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Sep 16, 2021
authority/src/lib.rs
Outdated
| #[pallet::weight(( | ||
| T::WeightInfo::authorize_call(), | ||
| DispatchClass::Operational, | ||
| Pays::No, |
There was a problem hiding this comment.
I am not 100% sure if this will still charge fee if this call failed. Can you verify?
There was a problem hiding this comment.
I know it is safe to do like this
open-runtime-module-library/oracle/src/lib.rs
Line 165 in 69426e8
An error will not return Pays::No.
There was a problem hiding this comment.
Post dispatch info will be { post_info: PostDispatchInfo { actual_weight: None, pays_fee: Pays::Yes }
xlc
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #608