Skip to content

XCM v1 #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 29, 2021
Merged

XCM v1 #614

merged 16 commits into from
Sep 29, 2021

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Sep 20, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #614 (a4fdb39) into master (4bd9eed) will decrease coverage by 0.13%.
The diff coverage is 82.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   76.40%   76.26%   -0.14%     
==========================================
  Files          76       77       +1     
  Lines        6267     6337      +70     
==========================================
+ Hits         4788     4833      +45     
- Misses       1479     1504      +25     
Impacted Files Coverage Δ
auction/src/mock.rs 90.00% <ø> (ø)
currencies/src/mock.rs 85.71% <ø> (ø)
gradually-update/src/mock.rs 83.33% <ø> (ø)
nft/src/mock.rs 75.00% <ø> (ø)
oracle/src/mock.rs 100.00% <ø> (ø)
rewards/src/mock.rs 85.71% <ø> (ø)
tokens/src/mock.rs 26.76% <ø> (ø)
traits/src/lib.rs 25.00% <ø> (ø)
unknown-tokens/src/mock.rs 83.33% <ø> (ø)
vesting/src/mock.rs 77.77% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd9eed...a4fdb39. Read the comment docs.

@shaunxw shaunxw requested a review from xlc September 20, 2021 01:45
@girazoki
Copy link
Contributor

Very nice work @shaunxw . We were in the process of upgrading xtokens to v1 too, but we were wondering how to split the execution fees when we transfer to non-reserve chains. I think the half-half solution that you implemented makes a lot of sense. I just had some minor comments, but other than that looks good

@xlc xlc merged commit d821705 into master Sep 29, 2021
@xlc xlc deleted the sw/xcm-v1 branch September 29, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants