Skip to content

send_as_sovereign as versioned xcm #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2021
Merged

send_as_sovereign as versioned xcm #652

merged 5 commits into from
Nov 11, 2021

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Nov 10, 2021

use VersionedXcm and VersionedMultiLocation

closes #643

@zqhxuyuan zqhxuyuan requested review from zjb0807 and xlc November 10, 2021 09:52
@codecov-commenter
Copy link

Codecov Report

Merging #652 (38bfb6f) into master (d69f226) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   76.02%   76.04%   +0.01%     
==========================================
  Files          78       78              
  Lines        6557     6561       +4     
==========================================
+ Hits         4985     4989       +4     
  Misses       1572     1572              
Impacted Files Coverage Δ
xcm/src/lib.rs 80.00% <100.00%> (+5.00%) ⬆️
xtokens/src/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69f226...38bfb6f. Read the comment docs.

@zjb0807
Copy link
Contributor

zjb0807 commented Nov 10, 2021

This can fix CI

cargo fmt --all

@zqhxuyuan
Copy link
Contributor Author

This can fix CI

cargo fmt --all

done, maybe we need githooks done this for us automatically?

@xlc
Copy link
Member

xlc commented Nov 11, 2021

If you are using orml within Acala, the githook of Acala should do the auto format

https://github.com/AcalaNetwork/Acala/blob/master/Makefile#L119

@xlc xlc merged commit 55d5276 into master Nov 11, 2021
@xlc xlc deleted the send_sovereign_version branch November 11, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update send_as_sovereign to use versioned XCM structs
4 participants