Skip to content

Refactor/tokens events #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Refactor/tokens events #729

merged 6 commits into from
Apr 26, 2022

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Apr 22, 2022

Added events so all operations with balance changes deposit events
Added unit test to ensure these events are emitted

Fixes #726

Roy Yang added 2 commits April 22, 2022 14:45
… total issuances changes happen.

Added unit tests to test these functions will deposit events correctly
…so transfer event is emitted last (instead of endowed).

Removed some redundant deposit_event for transfer, to avoid double transfer event emission
@syan095 syan095 requested review from wangjj9219 and shaunxw April 22, 2022 04:20
All events are deposited at implementation level instead
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #729 (18d8eb3) into master (2b5d4ce) will increase coverage by 0.39%.
The diff coverage is 92.89%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   75.21%   75.61%   +0.39%     
==========================================
  Files          84       84              
  Lines        7643     7766     +123     
==========================================
+ Hits         5749     5872     +123     
  Misses       1894     1894              
Impacted Files Coverage Δ
currencies/src/mock.rs 94.73% <ø> (ø)
tokens/src/mock.rs 31.14% <ø> (ø)
currencies/src/lib.rs 50.99% <81.81%> (-5.29%) ⬇️
tokens/src/lib.rs 85.54% <86.31%> (+0.92%) ⬆️
currencies/src/tests.rs 100.00% <100.00%> (ø)
tokens/src/tests.rs 99.84% <100.00%> (+0.01%) ⬆️
nft/src/mock.rs 100.00% <0.00%> (ø)
oracle/src/mock.rs 100.00% <0.00%> (ø)
auction/src/mock.rs 100.00% <0.00%> (ø)
... and 11 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@syan095 syan095 requested a review from shaunxw April 26, 2022 05:29
@shaunxw shaunxw merged commit d42fdd6 into master Apr 26, 2022
@shaunxw shaunxw deleted the refactor/tokens-events branch April 26, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events in tokens pallet do not completely cover balance changes
3 participants