-
Notifications
You must be signed in to change notification settings - Fork 300
Refactor/tokens events #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… total issuances changes happen. Added unit tests to test these functions will deposit events correctly
…so transfer event is emitted last (instead of endowed). Removed some redundant deposit_event for transfer, to avoid double transfer event emission
All events are deposited at implementation level instead
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
==========================================
+ Coverage 75.21% 75.61% +0.39%
==========================================
Files 84 84
Lines 7643 7766 +123
==========================================
+ Hits 5749 5872 +123
Misses 1894 1894
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
shaunxw
reviewed
Apr 25, 2022
shaunxw
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added events so all operations with balance changes deposit events
Added unit test to ensure these events are emitted
Fixes #726