asset-registry: Pass Asset Id to AuthorityOrigin #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different AssetId's may require different origin checks, which is currently not possible. These changes use EnsureOriginWithArg to allow users of this pallet to tailor the origin check to take the `asset_id` itself in consideration when choosing the specific `EnsureOrigin` implementation to be applied.
xlc
reviewed
Jun 6, 2022
shaunxw
reviewed
Jun 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 77.90% 78.04% +0.13%
==========================================
Files 100 100
Lines 9665 9728 +63
==========================================
+ Hits 7530 7592 +62
- Misses 2135 2136 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@xlc I will fix the git conflicts and the compilation errors around successful_origin. |
NunoAlexandre
commented
Jun 8, 2022
xlc
approved these changes
Jun 8, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different AssetId's may require different origin checks, which is currently not supported.
The changes proposed here make the switch to use
EnsureOriginWithArgto allow users of this pallet to tailor the origin check to take theasset_iditself in consideration when choosing the specificEnsureOriginimplementation to be applied.Fwiw, this feature is a must for our use case at Centrifuge where we need to have a tailored origin check when registering/updating tranche tokens.