asset-registry: And and Implement Inspect + Mutate traits
#767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine. Testing failing. |
Merged
The AssetMetadata type is needed by the Inspect and Mutate traits so it needs to be in a shared place. While it's fine for the pallet to depend on the traits::asset_registry, the inverse not so much, so we move the struct to the traits section and import it here.
NunoAlexandre
force-pushed
the
asset-registry/inspect+mutate
branch
from
9901ad1 to
5074049
Compare
|
@xlc It's ready for another round |
zqhxuyuan
reviewed
Jun 13, 2022
Doing so makes logical sense and smoothes the update to this new version.
|
@zqhxuyuan I just pushed one extra commit to |
zqhxuyuan
approved these changes
Jun 13, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for loosely coupling of the
orml_asset_registrypallet instead of forcing other pallets into a tight dependency.This is particularly helpful for us at Centrifuge where we need to pass the asset-registry to a few pallets to query asset metadata and register tranche tokens.