-
Notifications
You must be signed in to change notification settings - Fork 300
Oracle: allow multiple feed values from inner calls #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this works. Just need some tests and docs. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #920 +/- ##
=======================================
Coverage 78.21% 78.21%
=======================================
Files 105 105
Lines 10621 10623 +2
=======================================
+ Hits 8307 8309 +2
Misses 2314 2314
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Would you agree to add to this PR a minor breaking change to allow passing |
I think it is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready for review. I've also added the test part related to these changes.
Description
This PR shows an example of an implementation to allow calling
feed_value()
multiple times internally, avoiding theAlreadyFeeded
error without being a breaking change and without effecting to the extrinsic behaviorRelated issue: #919