Fix MessageQueue pallet order in mocks #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
=======================================
Coverage 78.44% 78.44%
=======================================
Files 105 105
Lines 10771 10771
=======================================
Hits 8449 8449
Misses 2322 2322
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can you provide elaborate bit more why this is needed? If the orders are important, we need some code comments to explicitly document the requirement. |
Yes of course, I've just updated the PR's description. |
xlc
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent getting some encoding errors with XCM related tests in the future.
Edit: To give more context, the reason why this change is needed is because the new
MessageQueuepallet should be placed at the same index where the oldParasUmppallet was situated before it was removed in the upgrade to v0.9.43.If we test the execution of an upward message with the current mock configuration, in most of the cases it will pass without any problem, but in some other ones it will fail while processing the XCM Transact instruction, more specifically while decoding the call that this instruction receives. This was the case in Moonbeam for instance, where we encountered that some XCM tests were failing due to this while testing the upgrade to v0.9.43. These issues got solved by placing the new
MessageQueuepallet in the correct index.