Add loguru for logging #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raghu017
commented
May 25, 2023
raghu017
commented
- Add loguru for logging
- Change PII logging to debug only
|
Hi @isafulf, this is part of the improvements we are making for Azure Open AI. This project already had a dependency on loguru (by indirect reference), so @raghu017 is migrating all of the print statements to it along with switching all PII to debug statements. Let us know if there is anything you need from us. |
added 2 commits
May 30, 2023 15:03
|
@isafulf Can you take a look at the PR? |
isafulf
reviewed
May 31, 2023
| @@ -252,7 +253,7 @@ def create_results(data): | |||
| QueryResult(query=query.query, results=results) | |||
| ) | |||
| except Exception as e: | |||
| print("error:", e) | |||
| logger.exception("error:", e) | |||
There was a problem hiding this comment.
Doesn't logger.exception already logs the stack trace along with the error message?
So: logger.exception("<descriptive message>") should be sufficient, this applies to all cases in the PR
There was a problem hiding this comment.
Pushed new changes, replaced exception with error. Exception is verbose stack trace and it is logging PII. Yes this is tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.