-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Container script firewall is overly restrictive #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note: I'm looking into this for myself but wanted to drop an issue as I assume this behavior others will want. |
Added --allow-outbound flag to the run_in_container.sh script tree, if set, outbound firewall rules won't be turned on allowing container to connect to things like npm, run tests, perform git actions etc. Signed-off-by: BadPirate <[email protected]>
Added --allow-outbound flag to the run_in_container.sh script tree, if set, outbound firewall rules won't be turned on allowing container to connect to things like npm, run tests, perform git actions etc. Signed-off-by: BadPirate <[email protected]>
This is actually intentional, at least for now - sorry for the confusion and lack of documentation! There's a few different risks when it comes to outbound network access, like:
We'll have guidance soon on how to do this safely, but since you've already started #383 I think it's reasonable to expose an argument like |
Oh sorry, just noted your response here. What you say makes sense. If it is really dangerous, I might recommend opening an issue with the Mac client sandbox, Apple's |
I was thinking about safe browsing too - could it be server side like when using chatgpt? so not doing request from client machine but from openai servers. I assume the standard browsing on chatgpt already has features of not being able to post user content; due to sandboxing any prompt injection would be limited to failing the task at hand. I guess worst case is it proposes vulnerable, hacked code to the user and user is not paying attention? The utility I'm looking for is reading related docs and repos that are on the internet. |
For my use case at least, I found the apple sandbox and the container sandbox overly restrictive. Simple case: Asking codex to make changes, and test those changes before coming back to me (Otherwise I have to go multiple rounds as it stumbles through development)
|
What version of Codex is running?
0.1.2504172351
Which model were you using?
any
What platform is your computer?
MacOS
What steps can reproduce the bug?
run-in-container.sh
script to open codexExpectation:
Should be able to make benign internet requests
Actual:
All outbound traffic is blocked, this forces manual interventions for adding tools (which is fine because it's in the container), running commands like yarn install among many other little grievances.
What is the expected behavior?
Docker container should protect / prevent calls to host machine, but allow internet access.
What do you see instead?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: