Skip to content

<codex-rs> Implements persistent command history functionality #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rohanPAnkam
Copy link

This PR implements persistent command history functionality in the TUI application.
The implementation includes command storage, sensitive command filtering, and history management commands.

  • Commands are stored in ~/.codex/history.json
  • History is loaded on startup and saved after each command
  • History file is stored in user's home directory
  • File permissions are set to user-only access

I have read the CLA Document and I hereby sign the CLA

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@rohanPAnkam
Copy link
Author

recheck

@rohanPAnkam
Copy link
Author

recheck

@rohanPAnkam rohanPAnkam reopened this May 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
@bolinfest
Copy link
Collaborator

FYI, I am actively working on this feature in #939.

@bolinfest
Copy link
Collaborator

@rohanPAnkam sorry that we raced on this. I just merged #939. As you can see from the PR body, I took a slightly different approach than that of the TypeScript CLI, but as noted, I believe it is also more robust to things like concurrent writes.

Please try it out and I would be interested in enhancements for this feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants