Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Basics of the Agents SDK #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
The Basics of the Agents SDK #1723
Changes from 10 commits
1995485
c4dea4a
db6b766
a07ba41
b66b72c
7d73195
493ebf5
bfd45d4
dbd487d
956f41f
45967cc
098dca9
7ae6d27
0f28df3
1140290
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Prep takes 45min to run, around 1k rows to process. This might be a bit long for anyone to wait while looking into the cookbook
Error ValueError: Expected a non-empty value for
vector_store_id
but received NoneThe CB doesn't set or create the vector store, and you need to manually add the key to a store for it to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upload_cache.json files exist in your example, because of this they are blocking the file upload. Blocking a new filestore to be used. It also leads to error missmatch on missing files due to not having the right IDs being generated
deleting all caches allows to upload the files into the vector store - takes 8min
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into this issue twice, which has to do with the history being persistent

Where if I run the prompt without any history it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah looks like I never pushed my update to optimize the API calls 😨. It now takes ~3 mins!
I removed the cached files.
I don't understand the last screenshot so we can chat through this tomorrow.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.