v2 ChatCompletionMessage.ToParams() returns an empty slice of ToolCalls

[wangxj03]

When no tool call is present, ToParams returns an empty slice. This causes an issue when continuing the conversation, as the chat completion API expects tool_calls to contain at least one element.

panic: POST "https://api.openai.com/v1/chat/completions": 400 Bad Request {
            "message": "Invalid 'messages[4].tool_calls': empty array. Expected an array with minimum length 1, but got an empty array instead.",
            "type": "invalid_request_error",
            "param": "messages[4].tool_calls",
            "code": "empty_array"
          }

Trace:

[wangxj03]

@jacobzim-stl please take a look at this v2 issue. The code was working fine in v1. Thanks!

[adrianliechti]

I noted that this method returns nulls Content too.
In the screenshot, there is Content set, but the JSON.Content not. Which results that the toParam Method returns an empty Value

if meta.IsPresent() {
	return param.NewOpt(value)
}

if meta.IsExplicitNull() {
	return param.NullOpt[T]()
}

return param.Opt[T]{}

[jacobzim-stl]

Thanks for the report, working on shipping a fix now.

[adrianliechti]

@jacobzim-stl

just saw your commit:

if r.JSON.Content.IsPresent() {
	p.Content.OfString.Value = r.Content
}
if r.JSON.Refusal.IsPresent() {
	p.Refusal = String(r.Refusal)
}

just for your info:
p.Content is still not set after the method; even if non-empty on r.Content

Maybe you have to set something like:

if r.Content != "" {
p.Content.OfString.Value = r.Content
}

before the JSON Blocks; or ensure the JSON Values are actual set (they are all empty)

r.JSON.Content => Empty
r.Content => set

I am using a a openai.ChatCompletionAccumulator{}

[jacobzim-stl]

Thanks for the catch

[adrianliechti]

ciao @jacobzim-stl,

thanks a ton for your fast hacking!
I can confirm it look much better now!

maybe another hint for the relase notes:
openai.ToolMessage seems to change the parameters (toolID, content vs. content, toolID)
since both were strings, this was a bit tricky to figure out :)

[jacobzim-stl]

The ToParam issue should be resolved.

@adrianliechti I appreciate the feedback, I'll add a note to the migration guide.