-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix: Malformed error message formatting in makeMessage() function #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ac-mmi
wants to merge
22
commits into
openai:master
Choose a base branch
from
ac-mmi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3ce189b
Add files via upload
ac-mmi ed4b7bd
Add files via upload
ac-mmi 260b0c0
Add files via upload
ac-mmi 1bd2eeb
Add files via upload
ac-mmi 08d1ccb
Merge branch 'master' into master
ac-mmi 2778f41
Merge branch 'master' into master
ac-mmi 6000d8d
Merge branch 'master' into master
ac-mmi 8a950bc
Add files via upload
ac-mmi 61c2706
Merge branch 'master' into master
ac-mmi ebbc120
Merge branch 'master' into master
ac-mmi 06cea6c
Merge branch 'master' into master
ac-mmi 7c3a2b4
Merge branch 'master' into master
ac-mmi 9daa445
Merge branch 'master' into master
ac-mmi c1c94d5
Merge branch 'master' into master
ac-mmi 40fa884
Merge branch 'master' into master
ac-mmi 175cfcf
Merge branch 'master' into master
ac-mmi 58edc18
Merge branch 'master' into master
ac-mmi 3bd57d6
Merge branch 'master' into master
ac-mmi bbce1ee
Merge branch 'master' into master
ac-mmi 2f679e6
Merge branch 'master' into master
ac-mmi 32d71e8
Merge branch 'master' into master
ac-mmi ed09137
Merge branch 'master' into master
ac-mmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we extract the error message formatting logic into a separate function for better readability and maintainability?
Additionally, if we have existing tests, could we add test cases for the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made a separate function for formatmessage inside the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsaiprakash90 I couldn't find any tests specifically targeting the APIError class