Mislabeled warning

[chamini2]

Is your feature request related to a problem? Please describe.
There is --fail-on-warning that fails for warnings or errors, but no --fail-on-error only to fail for errors (ignoring warnings)

Describe the solution you'd like
--fail-on-error only to fail for errors (ignoring warnings)

Describe alternatives you've considered
None

Additional context
To make a GitHub Action fail for errors only.

[dbanty]

I'm a bit confused, failing on only errors should be the default behavior. --fail-on-warning should turn on failing for warnings, but failing on errors should always be true. Is that not the case? If not, then this is a bug.

[chamini2]

I believe it's not failing on errors, we got:

ERROR parsing PUT /monitoring-profiles/{profile-name}/job within monitoring_profile_controller. Endpoint will not be generated.
Incorrect path templating for /monitoring-profiles/{profile-name}/job (Path parameters do not match with path)
ERROR parsing GET /monitoring-profiles/{profile-name} within monitoring_profile_controller. Endpoint will not be generated.
Incorrect path templating for /monitoring-profiles/{profile-name} (Path parameters do not match with path)
ERROR parsing GET /monitoring-profiles/{profile-name}/jobs within monitoring_profile_controller. Endpoint will not be generated.
Incorrect path templating for /monitoring-profiles/{profile-name}/jobs (Path parameters do not match with path)
WARNING parsing PUT /feature-groups/schedule/offline-to-online-etl/bigquery-firestore within feature_group_load_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'*/*': MediaType(media_type_schema=Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, type=<DataType.ARRAY: 'array'>, allOf=None, oneOf=[], anyOf=[], schema_not=None, items=Reference(ref='#/components/schemas/FeatureGroupLoad'), properties=None, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None), example=None, examples=None, encoding=None)}, links=None)
WARNING parsing GET /feature-groups/{featureGroup}/load within feature_group_load_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'*/*': MediaType(media_type_schema=Reference(ref='#/components/schemas/FeatureGroupLoad'), example=None, examples=None, encoding=None)}, links=None)
WARNING parsing GET /service-account/notebook-role/status within service_account_status_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'text/plain': MediaType(media_type_schema=Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, type=<DataType.STRING: 'string'>, allOf=None, oneOf=[], anyOf=[], schema_not=None, items=None, properties=None, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None), example=None, examples=None, encoding=None)}, links=None)
WARNING parsing GET /service-account/api-client-role/status within service_account_status_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'text/plain': MediaType(media_type_schema=Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, type=<DataType.STRING: 'string'>, allOf=None, oneOf=[], anyOf=[], schema_not=None, items=None, properties=None, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None), example=None, examples=None, encoding=None)}, links=None)
Skipping Integration
autoflake is not in PATH
Skipping Integration
isort is not in PATH
Skipping Integration
black is not in PATH
If you believe this was a mistake or this tool is missing a feature you need, please open an issue at https://github.com/triaxtec/openapi-python-client/issues/new/choose

and it did not end as error

[chamini2]

any ideas? @dbanty

[dbanty]

I haven't forgotten about you, I've just been on vacation 🏖. I should be able to reproduce and fix it this weekend.

[chamini2]

Thank you!

[dbanty]

Well I found the issue 😓. Turns out that thing labeled "ERROR" is actually a warning... it can't generate the one endpoint but it can keep generating others so it actually just skips that. Clearly it used to be an error at some point and I never updated the text... confusing. I'm going to update the text for 0.10.5. I should probably have a clearer indication of the level of any given message in a future change.

[chamini2]

Thanks dbanty! Could you also review openapi-generators/openapi-python-client-action#4, it's related to the same problem I found.