Skip to content

setup.py generated by --meta=setup option does not include subpackages when distributions are created #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tedo-benchling opened this issue Jan 25, 2022 · 0 comments
Closed

setup.py generated by --meta=setup option does not include subpackages when distributions are created #575

tedo-benchling opened this issue Jan 25, 2022 · 0 comments
Labels
🐞bug Something isn't working

Comments

@tedo-benchling
Copy link
Contributor

tedo-benchling commented Jan 25, 2022 •
edited
Loading

Describe the bug
Wheel/tar.gz files created by running python setup.py bdist_wheel are missing the nested api/model packages

To Reproduce
Steps to reproduce the behavior:

  1. Run openapi-python-client generate --path --meta=setup
  2. cd into the generated directory
  3. run rm -rf build dist && python setup.py bdist_wheel
  4. unzip -l dist/*.whl and note that some of the files are missing

Expected behavior
The generated wheel or tar.gz file should contain all of the files for the package.

OpenAPI Spec File
Any open API json should create this issue.

Desktop (please complete the following information):

  • OS: mac os 11.6
  • Python Version: 3.6.9
  • openapi-python-client version: 0.10.7

Additional context
This was introduced when the "fix" for #520 was merged in #521
@tedo-benchling tedo-benchling added the 🐞bug Something isn't working label Jan 25, 2022
tedo-benchling added a commit to tedo-benchling/openapi-python-client that referenced this issue Jan 25, 2022
@tedo-benchling
Use find_packages() to get nested packages (closes openapi-generators…
b112e87 
…#575)

When openapi-python-client is used to with the
--meta=setup option the generated setup.py needs to
use setuptools.find_packages() to find the top-level
and all of the nested pacakges in the directory
so that distributions include them
@dbanty dbanty closed this as completed in 3152663 Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tedo-benchling