feat: Change optional Open API query parameters to allow `None #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285.
Instead of methods like
we will now generate
and treat
None
the same asUnset
.This is a bit different from the original proposal in the linked issue, but if you scroll down you can see that it's what was agreed upon in the end IIUC (though I wasn't sure if we agreed on what the default value should be). In addition, it has the benefit of preserving back-compat.
As part of this issue, I also tried to collapse nested
Optional
andUnion
types, so that what was formerlyUnion[Unset, Optional[int]]
orOptional[Union[Unset, int]]
is nowUnion[Unset, None, int]
.Two more minor changes I lumped into this PR:
safety check
was failing onpy==1.9.0
, although weirdly it was not failing in thegithub-actions
command)