Skip to content

feat: Add option to fail generating client if there are any warnings #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

forest-benchling
Copy link
Collaborator

For our case, we'd rather fail fast than have a potentially incomplete client. I'm open to opinions on the best interface here, like if the flag should be renamed.

@forest-benchling
Copy link
Collaborator Author

@dbanty @emann (cc @dtkav @GitOnUp)

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #427 (d1ad795) into main (032a4a4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #427   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1549      1548    -1     
=========================================
- Hits          1549      1548    -1     
Impacted Files Coverage Δ
openapi_python_client/cli.py 100.00% <100.00%> (ø)
openapi_python_client/parser/openapi.py 100.00% <0.00%> (ø)
openapi_python_client/parser/properties/schemas.py 100.00% <0.00%> (ø)
...enapi_python_client/parser/properties/converter.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032a4a4...d1ad795. Read the comment docs.

Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@dbanty dbanty changed the base branch from main to support/0.9.x May 24, 2021 23:26
@dbanty dbanty added this to the 0.9.2 milestone May 24, 2021
@dbanty dbanty merged commit 47a0e93 into openapi-generators:support/0.9.x May 24, 2021
@eli-bl eli-bl deleted the forest-fail-on-warning branch November 26, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants