Skip to content

docs: Remove openapi generation python2 compatibility claim #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rtaycher
Copy link
Contributor

@rtaycher rtaycher commented Sep 21, 2021

Seems like its slightly outdated according to #242

I haven't played enough with both for a deeper comparison but I think it would be nice to update the basics at least

remove python compatibility claim
add note about being written in python
fix double Gg, add periods
@rtaycher rtaycher changed the title Remove openapi generation python2 compatibility claim docs: Remove openapi generation python2 compatibility claim Sep 21, 2021
Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rtaycher!
I've had a few folks ask for an update here, thanks for kick starting it. I rephrased to focus on the positives of this generator instead of a comparison so it won't fall out of date again. What do you think?

I'm also thinking about adding a note around extensive testing... the openapitools generator has accidentally introduced breaking changes for me more times than I can count 😅

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #499 (a08970c) into main (6108b97) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #499   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         1609      1609           
=========================================
  Hits          1609      1609           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6108b97...a08970c. Read the comment docs.

rtaycher and others added 3 commits September 22, 2021 01:11
Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the note about Jinja2. Thanks!

@dbanty dbanty merged commit 5708074 into openapi-generators:main Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants