Skip to content

Use isort black profile to make compatible with black #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 25, 2021
Merged

Use isort black profile to make compatible with black #523

merged 5 commits into from
Oct 25, 2021

Conversation

johnthagen
Copy link
Collaborator

The best way to use isort with black is to use the dedicated black profile: https://pycqa.github.io/isort/docs/configuration/profiles.html

@dbanty
Copy link
Collaborator

dbanty commented Oct 25, 2021

Apparently I did this for the generator itself at some point but forgot to update to update the templates 😅. Could you update the no_poetry template too?

Thanks!!

@johnthagen
Copy link
Collaborator Author

Could you update the no_poetry template too?

Done.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #523 (e71a056) into main (9c3af86) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         1639      1639           
=========================================
  Hits          1639      1639           
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3af86...e71a056. Read the comment docs.

@dbanty dbanty added this to the 0.10.6 milestone Oct 25, 2021
@dbanty
Copy link
Collaborator

dbanty commented Oct 25, 2021

I decided to merge the two templates so it'll be easier to maintain in the future. Thanks for the contribution!

@dbanty dbanty merged commit bff6ae5 into openapi-generators:main Oct 25, 2021
@johnthagen johnthagen deleted the patch-1 branch October 25, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants