feat: Use httpx.request to allow bodies for all type of requests #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @MalteBecker, this looks great! did you test out a generated client with this against a real web server? Just in case there are any peculiarities with |
Codecov Report
@@ Coverage Diff @@
## main #547 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 1661 1661
=========================================
Hits 1661 1661 Continue to review full report at Codecov.
|
|
@dbanty I tested it with a few of our web APIs at it worked pretty fine. |
dbanty
previously approved these changes
Jan 7, 2022
dbanty
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #545 i changed every httpx call to use httpx.request instead of httpx.get/post/put/etc.