fix: Add underscore suffix if property name is datetime #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanty
added
🥚breaking
|
Awesome, thanks for the fix! I think the same is probably true of |
Codecov Report
@@ Coverage Diff @@
## main #558 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 1661 1661
=========================================
Hits 1661 1661
Continue to review full report at Codecov.
|
|
Ah, the conflict was with the module, not the class. So |
dbanty
pushed a commit
that referenced
this pull request
Jan 17, 2022
…e" [#557 & #558]. Thanks @kmray! Co-authored-by: Dylan Anthony <[email protected]> BREAKING CHANGE: `datetime` is now considered a reserved word anywhere, so any properties which were named `datetime` will now be named `datetime_`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a property is named
datetimeand contains a date-time format, this will cause a conflict between the property name and Python'sdatetime. This addsdatetimeto the set of reserved words which will cause an underscore suffix to be appended. This resolves #557.