Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Kotlin code improvements, schemas shortened, json schema keyword enum used #437

Merged
merged 10 commits into from
May 21, 2024

Conversation

spacether
Copy link
Contributor

@spacether spacether commented May 21, 2024

Kotlin code improvements

  • JsonSchemaInfo eliminated, json schema named args passed int to constructor
  • json schema keyword enum created and used for stored and disabled keywords

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/generate_samples_configs/python*
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title Kotlin: shortens JsonSchemaInfo code Kotlin code improvment, schemas shortened May 21, 2024
@spacether spacether changed the title Kotlin code improvment, schemas shortened Kotlin code improvements, schemas shortened, json schema keyword enum used May 21, 2024
@spacether spacether merged commit 5a44e50 into master May 21, 2024
6 checks passed
@spacether spacether deleted the kotlin_improves_json_schema_info branch May 21, 2024 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant