This repository was archived by the owner on Dec 25, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 14
Feature: overload endpoint #7
Merged
spacether
merged 11 commits into
openapi-json-schema-tools:master
from
EltonChou:feat_overload_endpoint
Oct 4, 2022
Merged
Feature: overload endpoint #7
spacether
merged 11 commits into
openapi-json-schema-tools:master
from
EltonChou:feat_overload_endpoint
Oct 4, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
reviewed
Oct 2, 2022
modules/openapi-json-schema-generator/src/main/resources/python/endpoint.handlebars
Show resolved
Hide resolved
spacether
reviewed
Oct 3, 2022
...st_body_post_additionalproperties_allows_a_schema_which_should_validate_request_body/post.py
Outdated
Show resolved
Hide resolved
@EltonChou want this to be a hacktoberfest PR? |
Sure. |
spacether
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for the more specific type hints!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/python*
.For Windows users, please run the script in Git BASH.