Skip to content

Skip updating contributors with unavailable GitHub accounts #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

htunnicliff
Copy link
Member

@htunnicliff htunnicliff commented Nov 6, 2024

Changes

Fixes #1990 and unblocks docs builds.

How to Review

Run the update-contributors script and see that user davidleger95 is skipped due to their account not existing anymore.

@htunnicliff htunnicliff requested a review from a team as a code owner November 6, 2024 17:33
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 9e00bbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2024

Deploying openapi-ts with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e00bbd
Status: ✅  Deploy successful!
Preview URL: https://e42a5872.openapi-ts.pages.dev
Branch Preview URL: https://ht-skip-deactivated-accounts.openapi-ts.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size
packages/openapi-fetch/dist/index.min.js 5.85 KB (0%)

@htunnicliff htunnicliff force-pushed the ht/skip-deactivated-accounts branch from a2cffdd to 9e00bbd Compare November 6, 2024 17:34
@htunnicliff htunnicliff self-assigned this Nov 6, 2024
@htunnicliff htunnicliff requested a review from drwpow November 6, 2024 17:35
@kerwanp
Copy link
Contributor

kerwanp commented Nov 6, 2024

Thanks! Works perfectly on my side

@kerwanp kerwanp merged commit 9971e7b into main Nov 6, 2024
10 checks passed
@kerwanp kerwanp deleted the ht/skip-deactivated-accounts branch November 6, 2024 18:32
DjordyKoert pushed a commit to DjordyKoert/openapi-typescript that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] update contributors scripts breaks builds when a GitHub account is deactivated
2 participants