Remove spaces in enum names #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
reviewed
Feb 21, 2019
src/swagger-2.ts
Outdated
| @@ -27,7 +27,7 @@ const TYPES: { [index: string]: string } = { | |||
| }; | |||
|
|
|||
| function capitalize(str: string) { | |||
| return `${str[0].toUpperCase()}${str.slice(1)}`; | |||
| return `${str[0].toUpperCase()}${str.slice(1).replace(' ', '')}`; | |||
There was a problem hiding this comment.
If it’s all the same, maybe this should go at the end of camelCase instead? I think camelCase is expecting non-spaces anyway.
Something like .replace(/\s+/g, '') (I think in your example, only the first space would be replaced, and then it would skip the rest—maybe).
There was a problem hiding this comment.
Actually, wait—camelCase should be replacing spaces with capital letters. 🤔 Why is that failing for 'American Express'?
enmand
force-pushed
the
dan/bugfix/enum-whitespace
branch
4 times, most recently
from
dbc9716 to
e8965d2
Compare
Enum values can be more than one word, so replace whitespace so that enum names are valid
enmand
force-pushed
the
dan/bugfix/enum-whitespace
branch
from
e8965d2 to
6e9d3c8
Compare
Closed
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum values can be more than one word, so replace whitespace so that enum names are valid