-
-
Notifications
You must be signed in to change notification settings - Fork 525
Add schema to postTransform options #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema to postTransform options #2049
Conversation
🦋 Changeset detectedLatest commit: aba4e09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9f5c655
to
be8de00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great code, great docs, and great tests! I don’t have any feedback
* Add schema to postTransform options Closes openapi-ts#2013 * fixup! Add schema to postTransform options Closes openapi-ts#2013 * fixup! Add schema to postTransform options Closes openapi-ts#2013 * fixup! Add schema to postTransform options
* Add schema to postTransform options (#2049) * Add schema to postTransform options Closes #2013 * fixup! Add schema to postTransform options Closes #2013 * fixup! Add schema to postTransform options Closes #2013 * fixup! Add schema to postTransform options * Add Netlify badge (#2065) * Only check GitHub token for docs build when update needed * Add Netlify badge * Use link * [ci] release (#2084) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix issue templates (#2088) * Add feat issues to projects (#2090) * Use const arrays for OpenAPI enum types Preserve capitalization of named, exported enum values. Type exported const values as const, instead of their location within the operations or components schemas. Derive and export types for enum values from concrete values in const arrays. Use derived enum value types in operations and components schemas. Use non-conflicting variable names for composed OpenAPI enums (anyOf: [enum1, enum2]) * Export type-predicates along when enumValues is true --------- Co-authored-by: Drew Powers <[email protected]> Co-authored-by: openapi-ts-bot <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closes #2013
Changes
schema
topostTransform
optionspostTransform
optionsschema
option to declare a string SetHow to Review
TransformNodeOptions
is extension is acceptable.schema
should be populated fortransform
options; it's redundant since the first argument to transform is already the schema node, but it introduces consistency between thetransform
andpostTrannsform
APIs that I think might be desirable.Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript) (I tried this and got swamped with changes, please advise!)