-
-
Notifications
You must be signed in to change notification settings - Fork 525
Fix CI #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 6dfb2c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openapi-ts canceled.
|
@@ -217,15 +217,11 @@ export default function createClient<Paths extends {}, Media extends MediaType = | |||
useSuspenseQuery(queryOptions(method, path, init as InitWithUnknowns<typeof init>, options), queryClient), | |||
useInfiniteQuery: (method, path, init, options, queryClient) => { | |||
const { pageParamName = "cursor", ...restOptions } = options; | |||
|
|||
const { queryKey } = queryOptions(method, path, init); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This teeeechnically adds a modicum of work, but barely. The other methods were already using this; we’re just dogfooding it here as well.
We probably could improve the queryFn
helper to work for useInfiniteQuery
but I didn’t want to make too big a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to make a issue for it?
return useInfiniteQuery( | ||
{ | ||
queryKey: [method, path, init] as const, | ||
queryFn: async <Method extends HttpMethod, Path extends PathsWithMethod<Paths, Method>>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to type this out; it was already inferred correctly
@@ -1763,6 +1763,164 @@ export interface paths { | |||
patch?: never; | |||
trace?: never; | |||
}; | |||
"/orgs/{org}/actions/hosted-runners": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but commit git noise for a test run
Also going to just force-merge this to turn CI green again with minimal changes. I wouldn’t force-through a substantial change in a package without a review. |
Changes
A bad merge broke CI. Minor type fix for
openapi-react-query
.How to Review
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)