Skip to content

Fix CI #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Fix CI #2120

merged 2 commits into from
Jan 25, 2025

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Jan 25, 2025

Changes

A bad merge broke CI. Minor type fix for openapi-react-query.

How to Review

  • CI should pass; this is a type-only change
    • Note: “Size Limit” check is expected to fail, because main branch is red

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@drwpow drwpow requested a review from a team as a code owner January 25, 2025 21:33
@drwpow drwpow requested a review from duncanbeevers January 25, 2025 21:33
Copy link

changeset-bot bot commented Jan 25, 2025

🦋 Changeset detected

Latest commit: 6dfb2c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-react-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for openapi-ts canceled.

Name Link
🔨 Latest commit 6dfb2c4
🔍 Latest deploy log https://app.netlify.com/sites/openapi-ts/deploys/679559476e896f00084ed789

@@ -217,15 +217,11 @@ export default function createClient<Paths extends {}, Media extends MediaType =
useSuspenseQuery(queryOptions(method, path, init as InitWithUnknowns<typeof init>, options), queryClient),
useInfiniteQuery: (method, path, init, options, queryClient) => {
const { pageParamName = "cursor", ...restOptions } = options;

const { queryKey } = queryOptions(method, path, init);
Copy link
Contributor Author

@drwpow drwpow Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This teeeechnically adds a modicum of work, but barely. The other methods were already using this; we’re just dogfooding it here as well.

We probably could improve the queryFn helper to work for useInfiniteQuery but I didn’t want to make too big a change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to make a issue for it?

return useInfiniteQuery(
{
queryKey: [method, path, init] as const,
queryFn: async <Method extends HttpMethod, Path extends PathsWithMethod<Paths, Method>>({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to type this out; it was already inferred correctly

@@ -1763,6 +1763,164 @@ export interface paths {
patch?: never;
trace?: never;
};
"/orgs/{org}/actions/hosted-runners": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but commit git noise for a test run

@drwpow
Copy link
Contributor Author

drwpow commented Jan 25, 2025

Also going to just force-merge this to turn CI green again with minimal changes. I wouldn’t force-through a substantial change in a package without a review.

@drwpow drwpow merged commit efea325 into main Jan 25, 2025
12 of 13 checks passed
@drwpow drwpow deleted the fix-ci branch January 25, 2025 21:39
@openapi-ts-bot openapi-ts-bot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants