Skip to content

Fix underscores in interface names #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Jul 18, 2019

When using nested objects, it wouldn’t transform underscores properly. Given:

properties: {
  remote_ids: {
    type: 'object', properties: { id: { type: 'string' } } },
  },
},

it would return the following interface:

interface UserRemote_ids {} // 🚫

This now returns the following, as expected:

interface UserRemoteIds {} // ✅

@drwpow drwpow force-pushed the dangodev/pascal-case-interfaces branch from 3d57472 to e9c2ed0 Compare July 18, 2019 21:29
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #29 into master will increase coverage by 2.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   95.65%   97.84%   +2.19%     
==========================================
  Files           2        2              
  Lines          92       93       +1     
  Branches       34       34              
==========================================
+ Hits           88       91       +3     
+ Misses          4        2       -2
Impacted Files Coverage Δ
src/swagger-2.ts 97.7% <100%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52204f4...76009cf. Read the comment docs.

@drwpow drwpow merged commit 40380ce into master Jul 18, 2019
@drwpow drwpow deleted the dangodev/pascal-case-interfaces branch July 18, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant