Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Issue/86 remove torch #215

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Issue/86 remove torch #215

merged 3 commits into from
Oct 11, 2021

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 11, 2021 •
edited
Loading

Pull Request

Description

Make torch an optional requirement

Fixes #86

How Has This Been Tested?

normal unittest

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested review from JackKelly and removed request for JackKelly October 11, 2021 10:39
@peterdudfield
Copy link
Contributor Author

Let me fix the tests first

JackKelly
JackKelly approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit a5af07b into main Oct 11, 2021
@peterdudfield peterdudfield deleted the issue/86-remove-torch branch October 11, 2021 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JackKelly JackKelly JackKelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove PyTorch from the code
2 participants
@peterdudfield @JackKelly