Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Issue/86 remove torch #329

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Issue/86 remove torch #329

merged 3 commits into from
Nov 3, 2021

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 3, 2021 •
edited
Loading

Pull Request

Description

Remove torch code from package

Have not removed torch code from old notebooks

Fixes #86

How Has This Been Tested?

Search the folders

  • nowcasting_dataset
  • tests

for the word 'torch' - its not there

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as draft November 3, 2021 08:09
@peterdudfield peterdudfield marked this pull request as ready for review November 3, 2021 08:41
jacobbieker
jacobbieker approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit bebc2ab into main Nov 3, 2021
@peterdudfield peterdudfield deleted the issue/86-remove-torch branch November 3, 2021 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbieker jacobbieker jacobbieker approved these changes

@JackKelly JackKelly Awaiting requested review from JackKelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove PyTorch from the code
2 participants
@peterdudfield @jacobbieker