-
Notifications
You must be signed in to change notification settings - Fork 571
runtime: Deduplicate phrasing in state attribute definitions #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: Deduplicate phrasing in state attribute definitions #145
Conversation
LGTM |
I like the style that reads like a sentence. For example: -* root (string) is the path to the container's bundle directory. |
81faf1e
to
49f1bbd
Compare
Replace: $ENTRY ($TYPE) $ENTRY is the ... with: $ENTRY ($TYPE) is the ... It's more concise and avoids the need to argue over Pid vs PID ;). And "reads like a sentence" is an easy style to check and remember [1]. [1]: opencontainers#145 (comment) Signed-off-by: W. Trevor King <[email protected]>
@wking looks like a funky rebase that is picking up other commits? |
On Wed, Sep 09, 2015 at 07:56:17PM -0700, Vincent Batts wrote:
I may have been bitten by the actions behind this IRC comment: 14:48 < vbatts> i just used github's API to force push master from a And here's the history I've seen for the master branch: $ git reflog origin/master Here's a graph of what I see: $ git log --graph --topo-order --oneline --decorate origin/master dedup-state-attribute-definitions fd0ff56
So it looks like this PR, the #163 merge, and the #159 merge were |
On Wed, Sep 09, 2015 at 08:25:32PM -0700, W. Trevor King wrote:
I haven't been able to figure out what was wrong from the IRC logs. 14:23 < vbatts> crosbymichael: what commit is your origin/master at So I'm not sure how you decided on fbac038, but I think you should |
49f1bbd
to
c496947
Compare
Replace: $ENTRY ($TYPE) $ENTRY is the ... with: $ENTRY ($TYPE) is the ... It's more concise and avoids the need to argue over Pid vs PID ;). And "reads like a sentence" is an easy style to check and remember [1]. [1]: opencontainers#145 (comment) Signed-off-by: W. Trevor King <[email protected]>
On Wed, Sep 09, 2015 at 07:56:17PM -0700, Vincent Batts wrote:
With 3f62423 and 712a746 you pulled in #159 and #163. Those were the |
LGTM |
This has been rolled into #211. |
Replace:
with:
It's more concise and avoids the need to argue over Pid vs PID ;).
This is my first commit from crosbymichael#1, rebased to pickup
the
version
addition that landed while #87 was in-flight.