-
Notifications
You must be signed in to change notification settings - Fork 891
Deprecated brew tap-pin usage consistently fails CI if cache is not present #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
And after I solve this in my fork, I'd like to submit a PR so that other new forks don't get stuck on this issue in the future. |
instead refer to the full package name when installing fixes opencv#266 context: https://brew.sh/2019/04/04/homebrew-2.1.0/ Homebrew/brew#5925
Fix for #266 - don't use deprecated brew tap-pin, instead refer to the full package name when installing
@skvark Thanks for merging! You might wanna trigger a new build so that cache is fully re-generated because of: https://travis-ci.org/skvark/opencv-python/jobs/622109414
|
I had click there myself once as well to finish setting up the initial cache. I think somehow the pull request might have triggered a cache rebuild for the main repo... |
Ah, yes. I cleared the Travis cache because if there's a long time between builds homebrew recipes fail to update sometimes which makes the cache build fail. |
instead refer to the full package name when installing fixes #266 context: https://brew.sh/2019/04/04/homebrew-2.1.0/ Homebrew/brew#5925
Expected behaviour
After forking, I expected the CI to work in the fork.
Actual behaviour
Builds are consistently failing due to usage of deprecated (see https://brew.sh/2019/04/04/homebrew-2.1.0/ and Homebrew/brew#5925)
brew tap-pin
functionality.The problem is in line 101 of
travis_config.sh
:In the main repo, the first part
brew tap --list-pinned | grep -qxF cartr/qt4
always succeeds, I assume because the cache always kicks in.In the fork however, it always falls through to
brew tap-pin cartr/qt4
because there is no cache, and then it always fails, so cache is never created. If only I could escape this catch 22 ;)Steps to reproduce
Bunch of examples: https://travis-ci.com/mbdevpl/opencv-python/builds
One specific log: https://travis-ci.com/mbdevpl/opencv-python/jobs/263773575 - in this build no changes have been made in the fork whatsoever, it's simply a build of current master branch.
Solution idea
I guess one quick solution to try would be to use:
But unfortunately as I am unfamiliar with the opencv-python CI setup, I have no idea about what should be in the
formula_name_here
. Would any one of maintainers be able to provide ideas to try?The text was updated successfully, but these errors were encountered: