Skip to content

Fixed the names of methods #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Fixed the names of methods #2222

merged 1 commit into from
Aug 15, 2019

Conversation

mut-ex
Copy link
Contributor

@mut-ex mut-ex commented Aug 13, 2019

This pullrequest changes

The reg module methods that were being used were incorrect

@alalek
Copy link
Member

alalek commented Aug 13, 2019

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@mut-ex mut-ex changed the base branch from master to 3.4 August 13, 2019 21:55
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 63c08d0 into opencv:3.4 Aug 15, 2019
opencv-pushbot pushed a commit that referenced this pull request Aug 15, 2019
@alalek alalek mentioned this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants