Add python bindings to cudaobjdetect, cudawarping and cudaarithm #2396

cudawarped · 2019-12-22T10:55:46Z

This pullrequest changes

Adds overloads to C++ functions to generate the missing python bindings for cudaobjdetect, cudawarping, cudaarithm and cudabgsegm functions.

Python tests have been added for the missing functions and all module specific python tests have also been moved here from the main repo.

force_builders=Custom
buildworker:Custom=linux-4
build_image:Custom=ubuntu-cuda:18.04

Add python wrapper to convolution funciton.

… internaly if not passed for python bindings consistency.

cudawarped · 2020-01-08T13:00:25Z

Moved module specific python cuda tests from main opencv repo.
Updated SURF headers to generate python bindings and modified cv::cuda::meanShiftSegmentation() implementation to generate bindings consistent with the python documentation.

alalek · 2020-01-09T15:59:40Z

Could you please re-check modules/xfeatures2d/misc/python/test/test_cuda_xfeatures2d.py test / bindings ?

Crash log with python 2.7 (problem is this=0x0):

Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x00007fffdce3b319 in (anonymous namespace)::SURF_CUDA_Invoker::SURF_CUDA_Invoker (this=0x7fffffffc0d0, surf=..., img=..., mask=...)
    at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/src/surf.cuda.cpp:148
148	            CV_Assert(surf_.nOctaves > 0 && surf_.nOctaveLayers > 0);
(gdb) p surf_
$1 = (cv::cuda::SURF_CUDA &) <error reading variable>
(gdb) bt
#0  0x00007fffdce3b319 in (anonymous namespace)::SURF_CUDA_Invoker::SURF_CUDA_Invoker (this=0x7fffffffc0d0, surf=..., img=..., mask=...)
    at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/src/surf.cuda.cpp:148
#1  0x00007fffdce3d01e in cv::cuda::SURF_CUDA::operator() (this=0x0, img=..., mask=..., keypoints=...) at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/src/surf.cuda.cpp:386
#2  0x00007fffe0ea06f8 in cv::cuda::SURF_CUDA::detect (this=0x0, img=..., mask=..., keypoints=...)
    at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/include/opencv2/xfeatures2d/cuda.hpp:156
#3  0x00007fffe0fb2363 in pyopencv_cv_cuda_cuda_SURF_CUDA_detect (self=0x7fffe2b3bef0, args=0x7fff93777460, kw=0x0)
    at modules/python_bindings_generator/pyopencv_generated_types_content.h:38382

Command line (../../dev is path to renamed "opencv" source repository):

PYTHONPATH=`pwd`/../../dev/modules/python/test ./setup_vars.sh gdb -ex r --args python ../../contrib/modules/xfeatures2d/misc/python/test/test_cuda_xfeatures2d.py --repo ../../dev

Python 3.7:

Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x00007fffdc36a319 in (anonymous namespace)::SURF_CUDA_Invoker::SURF_CUDA_Invoker (this=0x7fffffffbc50, surf=..., img=..., mask=...)
    at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/src/surf.cuda.cpp:148
148	            CV_Assert(surf_.nOctaves > 0 && surf_.nOctaveLayers > 0);
(gdb) bt
#0  0x00007fffdc36a319 in (anonymous namespace)::SURF_CUDA_Invoker::SURF_CUDA_Invoker (this=0x7fffffffbc50, surf=..., img=..., mask=...)
    at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/src/surf.cuda.cpp:148
#1  0x00007fffdc36c01e in cv::cuda::SURF_CUDA::operator() (this=0x0, img=..., mask=..., keypoints=...) at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/src/surf.cuda.cpp:386
#2  0x00007fffe061d6f2 in cv::cuda::SURF_CUDA::detect (this=0x0, img=..., mask=..., keypoints=...)
    at /home/alalek/projects/opencv/contrib/modules/xfeatures2d/include/opencv2/xfeatures2d/cuda.hpp:156
#3  0x00007fffe072f5ef in pyopencv_cv_cuda_cuda_SURF_CUDA_detect (self=0x7fff92d97790, args=0x7fff930c9280, kw=0x0)
    at modules/python_bindings_generator/pyopencv_generated_types_content.h:38382
#4  0x00007ffff7ba8598 in _PyMethodDef_RawFastCallKeywords () from /usr/lib/libpython3.7m.so.1.0
#5  0x00007ffff7bda76f in _PyMethodDescr_FastCallKeywords () from /usr/lib/libpython3.7m.so.1.0

cudawarped · 2020-01-09T16:34:49Z

Thanks looking into this.

cudawarped · 2020-01-10T10:23:18Z

Apologies I committed the old test case, before I introduced the create method.

I have left both the SURF_CUDA constructors unwrapped

    //! the default constructor
    SURF_CUDA();
    //! the full constructor taking all the necessary parameters
    explicit SURF_CUDA(double _hessianThreshold, int _nOctaves=4,
         int _nOctaveLayers=2, bool _extended=false, float _keypointsRatio=0.01f, bool _upright = false);

meaning that constructing cuSurf as

cuSurf = cv.cuda_SURF_CUDA(hessianThreshold,nOctaves,nOctaveLayers,extended,keypointsRatio,upright)

will construct and empty object and still throw an exception when calling

cuSurf.detect(cuMat,cv.cuda_GpuMat())

However this does force the user to call create() allowing python to catch the following exception

OpenCV(4.2.0-dev) Error: The function/feature is not implemented (This algorithm is patented and is excluded in this configuration. Set OPENCV_ENABLE_NONFREE CMake option and rebuild the library) in cv::cuda::SURF_CUDA::create, file \modules\xfeatures2d\src\surf.cuda.cpp, line 56
s

when not compiled with OPENCV_ENABLE_NONFREE=ON and appears to be consistent with the behaviour of methods in the main repo. e.g.

bgmog2 = cv.BackgroundSubtractorMOG2()

works, however

bgmog2.getDefaultName()

throws an exception.

…rping documentation.

cudawarped · 2020-01-15T12:31:36Z

Overloads have been added for mog and mog2 getBackgroundImage() and the documentation updated to reflect the type of the transform matrix required by the cudawarping functions.

alalek

Looks good to me! Thank you 👍

…t argument.

cudawarped · 2020-01-20T18:31:22Z

Updated KeyPoints in cuda::ORB::Convert python wrapper to be an output argument.

modules/cudaobjdetect/include/opencv2/cudaobjdetect.hpp

alalek · 2020-01-24T11:47:24Z

modules/cudaimgproc/src/mssegmentation.cpp

+        _dst.create(src.size(), src.type());
+        Mat dstMat = _dst.getMat();
+        dst.copyTo(dstMat);


3 lines

Did you try just dst.copyTo(_dst); call?

No, but it works perfectly, I wrongly assumed that this worked the same for Mat and GpuMat.

I believe it makes sense to improve GpuMat support in .copyTo() implementation (in a separate PR).

OK I can take a look at that once this has been merged.

cudawarped · 2020-01-24T16:12:03Z

@alalek Made suggested changes.

asmorkalov · 2020-01-28T05:05:11Z

@cudawarped Please remove useless inline option in functions that I mentioned before and rework MOG and MOG2 test to check output objects shape at least.

alalek · 2020-01-28T07:31:45Z

that I mentioned before

where?

modules/cudaarithm/include/opencv2/cudaarithm.hpp

modules/cudaobjdetect/include/opencv2/cudaobjdetect.hpp

modules/cudabgsegm/misc/python/test/test_cudabgsegm.py

asmorkalov · 2020-01-29T06:10:43Z

👍

asmorkalov

👍

AditTuf · 2021-02-22T07:45:09Z

@cudawarped can you please till me how do I patch this changes on my Jetson Nano which also uses Ubuntu

cudawarped · 2021-02-22T08:51:56Z

@cudawarped can you please till me how do I patch this changes on my Jetson Nano which also uses Ubuntu

These changes were merged over a year ago. Using the latest version 4.5.1 will be sufficient.

Overload cudawarping functions to generate correct python bindings.

b049c4b

Add python wrapper to convolution funciton.

cudawarped changed the title ~~Overload cudawarping functions to generate correct python bindings.~~ Fix python bindings for cudawarping functions. Dec 22, 2019

cudawarped mentioned this pull request Dec 22, 2019

OpenCV cuda bindings for python seem receive wrong param types for cudawarping/src/warp.cpp #2393

Closed

Added shift and hog.

20e4292

cudawarped mentioned this pull request Dec 27, 2019

Add python tests for cudaobjdetect, cudawarping and cudaarithm modules opencv/opencv#16248

Merged

cudawarped changed the title ~~Fix python bindings for cudawarping functions.~~ Add python bindings to cudaobjdetect, cudawarping and cudaarithm Dec 27, 2019

cudawarped added 2 commits January 7, 2020 19:56

Moved cuda python tests to this repo and added python bindings to SURF.

d1a0ee1

Fix SURF documentation and allow meanshiftsegmention to create GpuMat…

6fe2053

… internaly if not passed for python bindings consistency.

asmorkalov self-assigned this Jan 10, 2020

Add correct cuda SURF test case.

eef4c4d

Fix python mog and mog2 python bindings, add tests and correct cudawa…

f84b12e

…rping documentation.

cudawarped mentioned this pull request Jan 15, 2020

Python cuda.BackgroundSubtractorMOG2 getBackgroundImage exception #2407

Closed

alalek approved these changes Jan 16, 2020

View reviewed changes

Updated KeyPoints in cuda::ORB::Convert python wrapper to be an outpu…

c8f2d2c

…t argument.

alalek reviewed Jan 24, 2020

View reviewed changes

Add changes suggested by alalek

d08816d

asmorkalov reviewed Jan 28, 2020

View reviewed changes

Added changes suggested by asmorkalov

5ed3c25

asmorkalov self-requested a review January 29, 2020 06:11

asmorkalov approved these changes Jan 29, 2020

View reviewed changes

alalek merged commit d7d6360 into opencv:master Jan 29, 2020

Add python bindings to cudaobjdetect, cudawarping and cudaarithm #2396

Add python bindings to cudaobjdetect, cudawarping and cudaarithm #2396

Uh oh!

Conversation

cudawarped commented Dec 22, 2019 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This pullrequest changes

Uh oh!

cudawarped commented Jan 8, 2020

Uh oh!

alalek commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cudawarped commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cudawarped commented Jan 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cudawarped commented Jan 15, 2020

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

cudawarped commented Jan 20, 2020

Uh oh!

Uh oh!

alalek Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

cudawarped Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

alalek Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

cudawarped Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

cudawarped commented Jan 24, 2020

Uh oh!

asmorkalov commented Jan 28, 2020

Uh oh!

alalek commented Jan 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Jan 29, 2020

Uh oh!

asmorkalov left a comment

Choose a reason for hiding this comment

Uh oh!

AditTuf commented Feb 22, 2021

Uh oh!

cudawarped commented Feb 22, 2021

Uh oh!

Uh oh!

cudawarped commented Dec 22, 2019 •

edited by alalek

Loading

alalek commented Jan 9, 2020 •

edited

Loading

cudawarped commented Jan 9, 2020 •

edited

Loading

cudawarped commented Jan 10, 2020 •

edited

Loading