Skip to content

videostab: Fix out of range data usage #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2020
Merged

videostab: Fix out of range data usage #2424

merged 3 commits into from
Feb 25, 2020

Conversation

GArik
Copy link
Contributor

@GArik GArik commented Feb 7, 2020 •
edited by alalek
Loading

Fix out of range data usage in video stabilizer and deblurrer.

Fixes opencv/opencv#5178

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository
  • The feature is well documented and sample code can be built with the project CMake

@GArik GArik requested a review from alalek February 7, 2020 16:44
@GArik GArik mentioned this pull request Feb 7, 2020
Closed
alalek
alalek reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have simple test for case from issue.

@GArik
Copy link
Contributor Author

GArik commented Feb 12, 2020

It would be nice to have simple test for case from issue.

I'll see what I can do.

@asmorkalov
Copy link
Contributor

@GArik friendly reminder.

@GArik GArik force-pushed the master branch 2 times, most recently from 5bc2b87 to f7c6a72 Compare February 19, 2020 16:25
@GArik
Copy link
Contributor Author

GArik commented Feb 19, 2020

Some basic UTs to reproduce the issue were added to the PR.

alalek
alalek reviewed Feb 19, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

alalek
alalek approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alalek alalek merged commit a0d9138 into opencv:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
bug category: videostab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

videostab: crashes when radius > number of input frames
3 participants
@GArik @asmorkalov @alalek