Skip to content

fix win, vs2019 build. missing header #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

Bleach665
Copy link
Contributor

Little win, vs2019 build fix

@alalek
Copy link
Member

alalek commented Nov 14, 2020

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@Bleach665 Bleach665 changed the base branch from master to 3.4 November 14, 2020 18:20
@Bleach665
Copy link
Contributor Author

Oops. I forgot again.
Done.

@opencv-pushbot opencv-pushbot merged commit 088dc14 into opencv:3.4 Nov 14, 2020
@Bleach665 Bleach665 deleted the fix_win_vs2019 branch November 14, 2020 23:51
@alalek alalek mentioned this pull request Nov 17, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants