Skip to content

fix search for one contour in _filterTooCloseCandidates() #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2022
Merged

fix search for one contour in _filterTooCloseCandidates() #3201

merged 3 commits into from
Mar 24, 2022

Conversation

AleksandrPanov
Copy link
Contributor

@AleksandrPanov AleksandrPanov commented Mar 18, 2022 •
edited
Loading

Merge with extra: opencv/opencv_extra#965

This PR fixes:

The problem was in _filterTooCloseCandidates(). Fixed and added regression_3192, regression_2492 tests.

opencv_extra=fix_filterTooCloseCandidates

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov linked an issue Mar 18, 2022 that may be closed by this pull request
Unable to detect Aruco marker under some circumstances #3192
Closed
@AleksandrPanov AleksandrPanov mentioned this pull request Mar 18, 2022
Merged
@AleksandrPanov AleksandrPanov linked an issue Mar 21, 2022 that may be closed by this pull request
Aruco detection is worsened since OpenCV 4.1.2 #2492
Closed
4 tasks
@AleksandrPanov AleksandrPanov mentioned this pull request Mar 21, 2022
Closed
4 tasks
@AleksandrPanov AleksandrPanov marked this pull request as ready for review March 21, 2022 10:34
@AleksandrPanov AleksandrPanov force-pushed the fix_filterTooCloseCandidates branch 4 times, most recently from bfd8d9a to 5141651 Compare March 22, 2022 18:05
@AleksandrPanov AleksandrPanov requested a review from alalek March 22, 2022 21:14
@AleksandrPanov AleksandrPanov force-pushed the fix_filterTooCloseCandidates branch from 5141651 to dab7ad0 Compare March 23, 2022 18:24
@asmorkalov asmorkalov self-requested a review March 24, 2022 05:25
@asmorkalov
Copy link
Contributor

@alalek your turn.

@alalek alalek merged commit ef5a7e8 into opencv:3.4 Mar 24, 2022
AleksandrPanov pushed a commit to AleksandrPanov/opencv_contrib that referenced this pull request Mar 25, 2022
@AleksandrPanov
Merge pull request opencv#3201 from AleksandrPanov:fix_filterTooClose…
798c005 
…Candidates

* fix search for one contour in _filterTooCloseCandidates()

* add regression_3192 test

* add regression_2492 test

(cherry picked from commit ef5a7e8)
@alalek alalek mentioned this pull request Mar 26, 2022
Merged
@asmorkalov asmorkalov mentioned this pull request Mar 28, 2022
Closed
6 tasks
@AleksandrPanov AleksandrPanov mentioned this pull request Apr 12, 2022
Closed
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
bug category: aruco test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to detect Aruco marker under some circumstances Aruco detection is worsened since OpenCV 4.1.2
3 participants
@AleksandrPanov @asmorkalov @alalek