Add new test data for extended camera calibration method #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the feature points are in the order as the same set of the object points, which makes the test data usable for testing calibration with CALIB_RELEASE_OBJECT flag.
opencv/modules/calib3d/test/test_cameracalibration.cpp must be sync with this test data file.
The new added calib2.dat is used for regression test of camera calibration with CALIB_RELEASE_OBJECT flag.
The new proposed calibration flag CALIB_RELEASE_OBJECT is removed. And the method selection is based on the range of the index of fixed point. For minus values, standard calibration method will be chosen. Values in a rational range will make the object-releasing calibration method selected.
l-bat
pushed a commit
to l-bat/opencv_extra
that referenced
this pull request
Apr 24, 2019
Merge pull request opencv#516 from savuor:cvtcolor_bgr2gray_8u_15bits * fixed perf data for PyrLK after bgr2gray 8u change * fixed perf data for new bgr2gray coeffs fixed issue #1754@contrib for ximgproc Merge pull request opencv#528 from xoox:calib-release-object Add new test data for extended camera calibration method (opencv#528) * Reorder object points and image points Now the feature points are in the order as the same set of the object points, which makes the test data usable for testing calibration with CALIB_RELEASE_OBJECT flag. * Add one line to store calibration flags opencv/modules/calib3d/test/test_cameracalibration.cpp must be sync with this test data file. * Add new test data for camera calibration The new added calib2.dat is used for regression test of camera calibration with CALIB_RELEASE_OBJECT flag. * Add a line of data for the index of fixed point The new proposed calibration flag CALIB_RELEASE_OBJECT is removed. And the method selection is based on the range of the index of fixed point. For minus values, standard calibration method will be chosen. Values in a rational range will make the object-releasing calibration method selected. fixed "false alarm" test failures in opencv_test_objdetect (i.e. removed some errorneously detected "non-faces" from the regression data) added sanity data for opencv_contrib/optflow module (since TVL1 optflow is now there and it does sanity check in perf tests) Test data for opencv/opencv_contrib#1791 fixed perf data for mRGBA
rayonnant14
pushed a commit
to rayonnant14/opencv_extra
that referenced
this pull request
Oct 25, 2019
Add new test data for extended camera calibration method (opencv#528) * Reorder object points and image points Now the feature points are in the order as the same set of the object points, which makes the test data usable for testing calibration with CALIB_RELEASE_OBJECT flag. * Add one line to store calibration flags opencv/modules/calib3d/test/test_cameracalibration.cpp must be sync with this test data file. * Add new test data for camera calibration The new added calib2.dat is used for regression test of camera calibration with CALIB_RELEASE_OBJECT flag. * Add a line of data for the index of fixed point The new proposed calibration flag CALIB_RELEASE_OBJECT is removed. And the method selection is based on the range of the index of fixed point. For minus values, standard calibration method will be chosen. Values in a rational range will make the object-releasing calibration method selected.
sl-sergei
pushed a commit
to sl-sergei/opencv_extra
that referenced
this pull request
Aug 29, 2020
Add new test data for extended camera calibration method (opencv#528) * Reorder object points and image points Now the feature points are in the order as the same set of the object points, which makes the test data usable for testing calibration with CALIB_RELEASE_OBJECT flag. * Add one line to store calibration flags opencv/modules/calib3d/test/test_cameracalibration.cpp must be sync with this test data file. * Add new test data for camera calibration The new added calib2.dat is used for regression test of camera calibration with CALIB_RELEASE_OBJECT flag. * Add a line of data for the index of fixed point The new proposed calibration flag CALIB_RELEASE_OBJECT is removed. And the method selection is based on the range of the index of fixed point. For minus values, standard calibration method will be chosen. Values in a rational range will make the object-releasing calibration method selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modified and added new data is used to test the extended camera
calibration method proposed in the PR opencv/opencv#12772. If that PR is merged into
OpenCV, this PR of test data should be also merged.
This pull request changes
Reorder 3D object coordinates of calib1.dat
The order of 3D object coordinates is modified, hence it's possible to
be used to test the extended camera calibration method with
CALIB_RELEASE_OBJECT specified.
The feature points in
calib1.datwere drawn as following. The red dotsare the first row of the checkerboard. These images look like no good
for camera calibration. See Dr. Strobl's comments on good calibration
images: xoox/calibrel#1 (comment)
Add new test data of calib2.dat
This test data file is used by regression test of the new extended
camera calibration method. The data is extracted from dataset3 of
calibrel_testdata. See xoox/calibrel#2 for explanation.