Remove .json files runtimes from DS notebook & removed the COPY instruction of them on the Dockerfile

[atheo89]

Remove .json files runtimes from DS notebook & removed the COPY instruction of them on the Dockerfile.

Related to: https://issues.redhat.com/browse/RHOAIENG-20241
Depends-on : opendatahub-io/kubeflow#576

Description

How Has This Been Tested?

1. Spawn a jupyterlab notebook
2. On runtimes menu on the left, check that there are not the runtimes embedded.

Note: Will be mounted via configmap from now on (opendatahub-io/kubeflow#576)

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[atheo89]

/hold
Keep this PR on hold till the corresponding one on odh-notebook-controller is merged.

[jiridanek]

error: build error: building at STEP "COPY ${DATASCIENCE_SOURCE_CODE}/runtime-images/ /opt/app-root/share/jupyter/metadata/runtime-images/": checking on sources under "/tmp/build/inputs": copier: stat: "/jupyter/datascience/ubi9-python-3.11/runtime-images": no such file or directory

this is legit fail?

[jiridanek]

/lgtm

[atheo89]

The error message tells

Please run 'bash ci/generate_code.sh' (the command from the previous step), commit the changed files locally, and push again.

Thanks, i didn't noticed that in the beginning I was checking on the errors 🤣

[jiridanek]

error: unable to copy layer sha256:671e140f1b5a4e81714622c975dd9e0ca4c51cc8d9309ce66151dab85aa19fda to quay.io/opendatahub/workbench-images: Patch "https://quay.io/v2/opendatahub/workbench-images/blobs/uploads/efb4c063-2ff0-4f4c-b334-d76da8831580": unexpected EOF

Clearly infra issue

[jiridanek]

/lgtm

[jstourac]

This LGTM in general. One question - update of the https://github.com/opendatahub-io/notebooks/blob/main/ci/check-runtime-images.sh check is planned as a separate PR? After this change the script is irrelevant until we rewrite it or incorporate the check into some other script. Let me know, I'm happy to update the script.

/lgtm

[atheo89]

This LGTM in general. One question - update of the https://github.com/opendatahub-io/notebooks/blob/main/ci/check-runtime-images.sh check is planned as a separate PR? After this change the script is irrelevant until we rewrite it or incorporate the check into some other script. Let me know, I'm happy to update the script.

/lgtm

Thanks for the review! The update wasn’t planned as part of this change. It would be great if you could take over the update.

[jstourac]

Thanks for the review! The update wasn’t planned as part of this change. It would be great if you could take over the update.

Okay, I'll raise a PR with the changes. Please note that it seems like images we currently refer in the imagestreams yaml files are a bit outdated (they still refer themselves as build from 2024b), so we should also update our runtimes we refer.

FTR: #1013

[atheo89]

Thanks for the review! The update wasn’t planned as part of this change. It would be great if you could take over the update.

Okay, I'll raise a PR with the changes. Please note that it seems like images we currently refer in the imagestreams yaml files are a bit outdated (they still refer themselves as build from 2024b), so we should also update our runtimes we refer.

FTR: #1013

Great! I just triggered that gha to update the runtimes with the new builds : https://github.com/opendatahub-io/notebooks/actions/runs/14379142856/job/40318553770
once the PR will generated and merged it and it we solve the build reference.

[atheo89]

This is done: #1014

[atheo89]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [atheo89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atheo89]

/override ci/prow/notebook-cuda-jupyter-pt-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror ci/prow/rocm-notebooks-e2e-tests

[openshift-ci]

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebook-cuda-jupyter-pt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/notebook-cuda-jupyter-pt-ubi9-python-3-11-pr-image-mirror ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.