Skip to content

chore: remove UnitTranslationPlugin #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Apr 11, 2024

TLDR: removed unwanted part from the asked #1330

@leangseu-edx leangseu-edx force-pushed the lk/remove-plugins-folder branch from c9e6fa2 to 0febc2c Compare April 18, 2024 17:37
@leangseu-edx leangseu-edx marked this pull request as ready for review April 18, 2024 17:37
@leangseu-edx leangseu-edx requested review from arbrandes and Rodra April 18, 2024 17:37
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (75f56ea) to head (1583d5d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.01%     
==========================================
  Files         292      292              
  Lines        5003     5002       -1     
  Branches     1267     1235      -32     
==========================================
  Hits         4416     4416              
+ Misses        571      570       -1     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Rodra Rodra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leangseu-edx leangseu-edx merged commit 72381a7 into master Apr 22, 2024
7 checks passed
@leangseu-edx leangseu-edx deleted the lk/remove-plugins-folder branch April 22, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants