Skip to content

feat: accessibility attributes for Course Navigation top bar #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link

Enhancing accessibility by adding aria-label to the tab bar’s

, assigning tablist role to the
with tab buttons, and setting tab, aria-selected, and aria-controls attributes on each button. Inactive tabs will be removed from the sequence with tabindex="-1", focusing on the active tab.

@openedx-webhooks
Copy link

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 25, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-HTML-attributes-for-Course-Navigation-top-bar branch from df625d5 to 0bf0497 Compare February 25, 2025 17:40
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (af432ea) to head (50e49c6).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
+ Coverage   90.18%   90.32%   +0.13%     
==========================================
  Files         339      338       -1     
  Lines        5810     5693     -117     
  Branches     1409     1383      -26     
==========================================
- Hits         5240     5142      -98     
+ Misses        552      534      -18     
+ Partials       18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd itsjeyd added the product review PR requires product review before merging label Feb 27, 2025
@itsjeyd
Copy link

itsjeyd commented Feb 27, 2025

@vladislavkeblysh Thank you for this contribution!

Same note about product review here.

@vladislavkeblysh vladislavkeblysh self-assigned this Mar 4, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-HTML-attributes-for-Course-Navigation-top-bar branch from 0bf0497 to 7e2a94c Compare March 5, 2025 09:25
@itsjeyd
Copy link

itsjeyd commented Apr 1, 2025

Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Apr 10, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-HTML-attributes-for-Course-Navigation-top-bar branch from 7e2a94c to fdb780d Compare April 14, 2025 10:51
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-HTML-attributes-for-Course-Navigation-top-bar branch 7 times, most recently from 56cb578 to 3ff5757 Compare April 15, 2025 10:53
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/accessibility-HTML-attributes-for-Course-Navigation-top-bar branch from a500e3a to 50e49c6 Compare April 15, 2025 11:10
@vladislavkeblysh
Copy link
Author

@itsjeyd Ready to review

@itsjeyd
Copy link

itsjeyd commented Apr 24, 2025

@vladislavkeblysh Same question here.

@itsjeyd itsjeyd removed the inactive PR author has been unresponsive for several months label Apr 24, 2025
@PKulkoRaccoonGang
Copy link
Contributor

[inform]: Awaiting Product Review

@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 24, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

5 participants