-
Notifications
You must be signed in to change notification settings - Fork 244
feat: accessibility attributes for Course Navigation top bar #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: accessibility attributes for Course Navigation top bar #1606
Conversation
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
df625d5
to
0bf0497
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1606 +/- ##
==========================================
+ Coverage 90.18% 90.32% +0.13%
==========================================
Files 339 338 -1
Lines 5810 5693 -117
Branches 1409 1383 -26
==========================================
- Hits 5240 5142 -98
+ Misses 552 534 -18
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@vladislavkeblysh Thank you for this contribution! Same note about product review here. |
0bf0497
to
7e2a94c
Compare
Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR? |
7e2a94c
to
fdb780d
Compare
56cb578
to
3ff5757
Compare
a500e3a
to
50e49c6
Compare
@itsjeyd Ready to review |
[inform]: Awaiting Product Review |
Sandbox deployment successful 🚀 |
Enhancing accessibility by adding aria-label to the tab bar’s
, assigning tablist role to the