Skip to content

feat: improved accessibility for Show/Hide Accordions #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link

@vladislavkeblysh vladislavkeblysh commented Mar 12, 2025

Improving accessibility by marking up accordion labels as headings that fit the logical structure of the page. The

    containing the show/hide sections will be assigned the role of presentation.

    1

@vladislavkeblysh vladislavkeblysh self-assigned this Mar 12, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 12, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (af432ea) to head (801def1).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1635      +/-   ##
==========================================
+ Coverage   90.18%   90.30%   +0.11%     
==========================================
  Files         339      338       -1     
  Lines        5810     5692     -118     
  Branches     1409     1342      -67     
==========================================
- Hits         5240     5140     -100     
+ Misses        552      535      -17     
+ Partials       18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd
Copy link

itsjeyd commented Mar 14, 2025

@vladislavkeblysh Thank you for this contribution! Since it seems to include user-facing changes, you'll likely need to get product approval for it. When you're ready please follow the instructions from the bot to get that process started.

@itsjeyd itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Mar 14, 2025
@itsjeyd itsjeyd added the product review PR requires product review before merging label Mar 14, 2025
@itsjeyd
Copy link

itsjeyd commented Apr 10, 2025

Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Apr 10, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/show-hide-accordion branch from da2fcec to c54fe0e Compare April 15, 2025 11:24
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/show-hide-accordion branch from dd4a639 to 801def1 Compare April 15, 2025 12:22
@vladislavkeblysh
Copy link
Author

@itsjeyd Ready to review

@PKulkoRaccoonGang
Copy link
Contributor

[inform]: Awaiting Product Review

@itsjeyd
Copy link

itsjeyd commented Apr 24, 2025

@vladislavkeblysh As @PKulkoRaccoonGang pointed out above, this PR will need to go through product review as a next step.

@itsjeyd itsjeyd removed the inactive PR author has been unresponsive for several months label Apr 24, 2025
@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants