fix: LmsHtmlFragment.css not found

[jciasenza]

Description

URL change

Changes Made
I changed the URL call to the Lms Html Fragment.css file, as it was poorly constructed.

On line 18, it used to be called BASE_URL, but it should be LEARNING_BASE_URL.

*Before:

*After:

[openedx-webhooks]

Thanks for the pull request, @jciasenza!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (d5a092b) to head (8e563c6).
Report is 22 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1659   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         338      338           
  Lines        5784     5784           
  Branches     1370     1407   +37     
=======================================
  Hits         5211     5211           
+ Misses        557      556    -1     
- Partials       16       17    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jciasenza]

Hi @brian-smith-tcril, When you can, tell me what you think about this error? If it's okay for us to do the merge, thanks.

[brian-smith-tcril]

Thanks for the PR @jciasenza! I think this change makes sense and we should land it!

@openedx/2u-aurora would any changes need to be made to 2U environments to handle this? It seems none of the .env files in this repo have LEARNING_BASE_URL set.

[jciasenza]

Thanks for the PR @jciasenza! I think this change makes sense and we should land it!

@openedx/2u-aurora would any changes need to be made to 2U environments to handle this? It seems none of the .env files in this repo have LEARNING_BASE_URL set.

I think you are right, I was testing it on my development instance, but now I realized that it is repeating the path, so I came up with another solution to make the path absolute with the '//'.

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[jciasenza]

Thanks @itsjeyd !!!

[itsjeyd]

Hey @brian-smith-tcril, since you already had a look at this PR would you be able to provide a full review for this PR and merge it when ready?

[brian-smith-tcril]

I've verified this error appears on PR sandboxes without this change, and does not appear on PR sandboxes with this change.

[brian-smith-tcril]

This will break if getConfig().BASE_URL includes a protocol already (//https://my.mfe.domain/static/LmsHtmlFragment.css is invalid)

It'd be great if this was standardized, but we probably need some logic to check for protocol in here.