Skip to content

Ignore the SDK in vendor config #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Conversation

alexellis
Copy link
Member

Signed-off-by: Alex Ellis (VMware) [email protected]

Description

Fix for #18

How Has This Been Tested?

  • fixes issue: faas-cli build error with dep #18 by ignoring the function SDK through
    use of Gopkg.toml. If there are two nested vendor folders with
    the same dependency it causes a build error.

Tested with a local build pairing with Michael Gasch

How are existing users impacted? What migration steps/scripts do we need?

Users may need to apply the same fix if they have already generated functions or Gopkg.toml files.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

- fixes issue: #18 by ignoring the function SDK through
use of Gopkg.toml. If there are two nested vendor folders with
the same dependency it causes a build error.

Tested with a local build pairing with Michael Gasch

Signed-off-by: Alex Ellis (VMware) <[email protected]>
@alexellis alexellis merged commit d3caa47 into master Jan 18, 2019
@alexellis alexellis deleted the alexellis2/ignore-vendor-sdk branch January 18, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant