-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8326951: since-checker - missing @ since tags #18055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e782170
f33d30a
cfe4323
2c04a9d
5da3f0d
c21d331
ba97724
3cec63e
9ddd230
4eaf032
7d6e969
97f4c94
390a21f
670acae
d3b8e64
e66fbf5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* | ||
* Copyright (c) 2008, 2023, Oracle and/or its affiliates. All rights reserved. | ||
* Copyright (c) 2008, 2024, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
|
@@ -7919,6 +7919,8 @@ private static void tryFinallyChecks(MethodHandle target, MethodHandle cleanup) | |
* handles is not {@code int}, or if the types of | ||
* the fallback handle and all of target handles are | ||
* not the same. | ||
* | ||
* @since 17 | ||
*/ | ||
public static MethodHandle tableSwitch(MethodHandle fallback, MethodHandle... targets) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This method was introduced in Java 17 through https://bugs.openjdk.org/browse/JDK-8263087. So this addition of |
||
Objects.requireNonNull(fallback); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* | ||
* Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved. | ||
* Copyright (c) 2003, 2024, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
|
@@ -50,6 +50,8 @@ public MalformedParameterizedTypeException() { | |
* Constructs a {@code MalformedParameterizedTypeException} with | ||
* the given detail message. | ||
* @param message the detail message; may be {@code null} | ||
* | ||
* @since 10 | ||
*/ | ||
public MalformedParameterizedTypeException(String message) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both this and the explicit no-arg constructor were introduced in this class through https://bugs.openjdk.org/browse/JDK-8183175 in Java 10. Since an (implicit) no-arg constructor was always available even before that change, it makes sense to add a |
||
super(message); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -397,6 +397,8 @@ public final MappedByteBuffer rewind() { | |
* {@code force()} on the returned buffer, will only act on the sub-range | ||
* of this buffer that the returned buffer represents, namely | ||
* {@code [position(),limit())}. | ||
* | ||
* @since 17 | ||
*/ | ||
@Override | ||
public abstract MappedByteBuffer slice(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This and the other 3 methods on which this |
||
|
@@ -410,19 +412,25 @@ public final MappedByteBuffer rewind() { | |
* of this buffer that the returned buffer represents, namely | ||
* {@code [index,index+length)}, where {@code index} and {@code length} are | ||
* assumed to satisfy the preconditions. | ||
* | ||
* @since 17 | ||
*/ | ||
@Override | ||
public abstract MappedByteBuffer slice(int index, int length); | ||
|
||
/** | ||
* {@inheritDoc} | ||
* | ||
* @since 17 | ||
*/ | ||
@Override | ||
public abstract MappedByteBuffer duplicate(); | ||
|
||
/** | ||
* {@inheritDoc} | ||
* @throws ReadOnlyBufferException {@inheritDoc} | ||
* | ||
* @since 17 | ||
*/ | ||
@Override | ||
public abstract MappedByteBuffer compact(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* | ||
* Copyright (c) 1995, 2021, Oracle and/or its affiliates. All rights reserved. | ||
* Copyright (c) 1995, 2024, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
|
@@ -185,6 +185,7 @@ public Properties() { | |
* accommodate this many elements | ||
* @throws IllegalArgumentException if the initial capacity is less than | ||
* zero. | ||
* @since 10 | ||
*/ | ||
public Properties(int initialCapacity) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This constructor was introduced in Java 10 through https://bugs.openjdk.org/browse/JDK-8189319, so adding |
||
this(null, initialCapacity); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -506,6 +506,8 @@ public float nextFloat() { | |
* {@inheritDoc} | ||
* @throws IllegalArgumentException {@inheritDoc} | ||
* @implNote {@inheritDoc} | ||
* | ||
* @since 17 | ||
*/ | ||
@Override | ||
public float nextFloat(float bound) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These 2 |
||
|
@@ -516,6 +518,8 @@ public float nextFloat(float bound) { | |
* {@inheritDoc} | ||
* @throws IllegalArgumentException {@inheritDoc} | ||
* @implNote {@inheritDoc} | ||
* | ||
* @since 17 | ||
*/ | ||
@Override | ||
public float nextFloat(float origin, float bound) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -336,6 +336,8 @@ public void setDictionary(byte[] dictionary) { | |
* @param dictionary the dictionary data bytes | ||
* @see Inflater#inflate | ||
* @see Inflater#getAdler() | ||
* | ||
* @since 11 | ||
*/ | ||
public void setDictionary(ByteBuffer dictionary) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This method was introduced in Java 11 through https://bugs.openjdk.org/browse/JDK-6341887. It appears to be an oversight that a |
||
synchronized (zsRef) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
@since 14
was added here as part of https://bugs.openjdk.org/browse/JDK-8187898. The CSR explains what the changes were https://bugs.openjdk.org/browse/JDK-8230625. As noted in that CSR's specification (and attached images), the change for this method in that issue ended up being just API clarification (through a@apiNote
) and no other change to this specific method. It continued to have the same signature including the throws clause that was previously available on this class through the superFilterOutputStream#write(byte[])
method.So removing this
@since 14
looks correct to me.